Conversation
…atrix4.html`, as the previous is too long to visual test regression. (2) Fix test case for coordClamp.
…, where 'x1' and 'x3' is considered the range boundary. (2) Disable the default clamp in `matrix.body/corner.data[i].coord`, because it consider the illegal input as "refer to the entire row/column", which is more likely to mislead users and no error message. Introduce option `matrix.body/corner.data[i].coordClamp` to enable it.
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21108@e0bfd3f |
Ovilia
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
option.textStyleas the default.matrix.body/corner.data[i].coord, because it consider the illegal input as "refer to the entire row/column", which is more likely to mislead users and no error message. And it is inconsistent with the default behavior ofchart.convertToLayout(where clamp is disabled by default). Introduce optionmatrix.body/corner.data[i].coordClampto enable it.Test
No unexpected result in visual test:
Visual Regression Test Report 20250716.html.zip
Doc
Updated in:
apache/echarts-doc commit: 5f3930c766b19e0d6be499d621c543b4c55c1707