Fix performance overhead caused by too much unknown classloading during hessian2 deserialization#7
Merged
beiwei30 merged 1 commit intoapache:masterfrom Feb 2, 2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
============================================
+ Coverage 24.16% 24.24% +0.08%
- Complexity 453 455 +2
============================================
Files 89 89
Lines 6287 6289 +2
Branches 1048 1048
============================================
+ Hits 1519 1525 +6
+ Misses 4550 4547 -3
+ Partials 218 217 -1
Continue to review full report at Codecov.
|
6 tasks
beiwei30
requested changes
Feb 1, 2019
lovepoem
reviewed
Feb 1, 2019
Member
|
merged. I will follow up with 'import star'. |
beiwei30
approved these changes
Feb 2, 2019
This was referenced Feb 2, 2019
Author
|
@beiwei30 Thanks for help remove'import star'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To avoid frequently class loading and to reduce performance overhead during the process of hessian2 deserialization for those classes are unknown in current classloader
Brief changelog
com.alibaba.com.caucho.hessian.io.SerializerFactory#getDeserializer(String type)