fix: test case of NetUtilsTest#testGetIpByHost#7553
Merged
AlbumenJ merged 1 commit intoapache:masterfrom Apr 15, 2021
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Make NetUtilsTest#testGetIpByHost() run successfully.
see #7552
Brief changelog
update NetUtilsTest#testGetIpByHost() test case
Reason
In some companies, there are short domains to simplify the full domain. So, the OPS team will set some rules to convert the short domain to IP address. Sometimes, the short domains is a string without separating with dots.
There are some examples in my company below:
run

ping dubborun

ping assdfasdfasdfasdrun

ping dubbo.localSolution
Update the domain and make sure the domain contains dot.
Also, we can see the domain
dubbohas been updated todubbo.localin the branch of 3.0So, we'd better update the domain from
dubbotodubbo.localVerifying this change
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.