Skip to content

Adjust the introduction of the xml rpc module#7544

Merged
AlbumenJ merged 1 commit intoapache:masterfrom
CrazyHZM:fix/fix_xml_rpc_pom
Apr 14, 2021
Merged

Adjust the introduction of the xml rpc module#7544
AlbumenJ merged 1 commit intoapache:masterfrom
CrazyHZM:fix/fix_xml_rpc_pom

Conversation

@CrazyHZM
Copy link
Copy Markdown
Member

What is the purpose of the change

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 6c779a9 into apache:master Apr 14, 2021
@CrazyHZM CrazyHZM deleted the fix/fix_xml_rpc_pom branch April 27, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants