Skip to content

Move ContextFilter to lowest order#7533

Merged
AlbumenJ merged 1 commit intoapache:masterfrom
AlbumenJ:fix_5842_context_filter
Apr 13, 2021
Merged

Move ContextFilter to lowest order#7533
AlbumenJ merged 1 commit intoapache:masterfrom
AlbumenJ:fix_5842_context_filter

Conversation

@AlbumenJ
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ commented Apr 12, 2021

What is the purpose of the change

Fix #5842

Move ContextFilter's order to the lowest, avoid RpcContext be cleared

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 12, 2021 •
edited
Loading

Codecov Report

Merging #7533 (80c099a) into master (27fbe77) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7533      +/-   ##
============================================
- Coverage     59.20%   59.17%   -0.03%     
  Complexity      502      502              
============================================
  Files          1076     1076              
  Lines         43364    43387      +23     
  Branches       6327     6332       +5     
============================================
+ Hits          25674    25676       +2     
- Misses        14850    14869      +19     
- Partials       2840     2842       +2
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/rpc/filter/ContextFilter.java 89.58% <ø> (ø) 0.00 <0.00> (ø)
...g/context/properties/DefaultDubboConfigBinder.java 42.85% <0.00%> (-57.15%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 70.21% <0.00%> (-4.26%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0.00%> (-3.28%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...org/apache/dubbo/registry/redis/RedisRegistry.java 49.01% <0.00%> (-0.80%) 27.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 59.14% <0.00%> (-0.61%) 0.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27fbe77...80c099a. Read the comment docs.

horizonzy
horizonzy approved these changes Apr 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit ba2692e into apache:master Apr 13, 2021
@AlbumenJ AlbumenJ mentioned this pull request Apr 13, 2021
Closed
6 tasks
@AlbumenJ AlbumenJ mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@horizonzy horizonzy horizonzy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

move ContextFilter's order to the lowest, avoid RpcContext be cleared

3 participants

@AlbumenJ @codecov-io @horizonzy