Codecov Report

Merging #7528 (2e00127) into master (790dfce) will decrease coverage by 0.52%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #7528      +/-   ##
============================================
- Coverage     59.33%   58.80%   -0.53%     
  Complexity      501      501              
============================================
  Files          1079     1076       -3     
  Lines         43331    43320      -11     
  Branches       6318     6294      -24     
============================================
- Hits          25709    25476     -233     
- Misses        14785    15000     +215     
- Partials       2837     2844       +7     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790dfce...2e00127. Read the comment docs.

What scene will be abnormal?

when i config a registry but havent add a dependency or cofig for a not exist registry, the exception does not have a log, every thing seem ok from log,but it does not work property actually

It just add log info than before, it's not necessary.
编码约定
抛出异常的地方不用打印日志，由最终处理异常者决定打印日志的级别，吃掉异常必需打印日志

when i config a registry but havent add a dependency or cofig for a not exist registry, the exception does not have a log, every thing seem ok from log,but it does not work property actually

Yes, the log didn't log this situation. It should be enhanced.
But the code can't fix it. The registryFactory is adaptive, the catch code block can't cover it.

when i config a registry but havent add a dependency or cofig for a not exist registry, the exception does not have a log, every thing seem ok from log,but it does not work property actually

Yes, the log didn't log this situation. It should be enhanced.
But the code can't fix it. The registryFactory is adaptive, the catch code block can't cover it.

Template Method Pattern is used in the registryFactory, i think it is the proper place to log error message.if other classes implement RegistryFactory and override the adaptive method shold log the message itself.

Template Method Pattern is used in the registryFactory, i think it is the proper place to log error message.if other classes implement RegistryFactory and override the adaptive method shold log the message itself.

Hi, If you config zookeeper registry without zookeeper-registry dependency, it will throw exception before AbstractRegistryFactory.getRegistry(URL url). You can debug the code at your local machine.