Skip to content

Optimize some code related to consul#7523

Merged
AlbumenJ merged 5 commits intoapache:masterfrom
xiaoheng1:up-dev-issue#7518
Apr 12, 2021
Merged

Optimize some code related to consul#7523
AlbumenJ merged 5 commits intoapache:masterfrom
xiaoheng1:up-dev-issue#7518

Conversation

@xiaoheng1
Copy link
Copy Markdown
Contributor

@xiaoheng1 xiaoheng1 commented Apr 9, 2021

What is the purpose of the change

Optimize some code related to consul

see more detail from #7518

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@xiaoheng1 xiaoheng1 changed the title Up dev issue#7518 Optimize some code related to consul Apr 9, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 11, 2021 •
edited
Loading

Codecov Report

Merging #7523 (5d78f6a) into master (0bcb02e) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7523      +/-   ##
============================================
- Coverage     59.23%   59.22%   -0.01%     
- Complexity      501      502       +1     
============================================
  Files          1079     1076       -3     
  Lines         43408    43364      -44     
  Branches       6335     6327       -8     
============================================
- Hits          25711    25681      -30     
+ Misses        14856    14842      -14     
  Partials       2841     2841
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...onfigcenter/consul/ConsulDynamicConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bo/metadata/store/consul/ConsulMetadataReport.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../dubbo/registry/consul/AbstractConsulRegistry.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../dubbo/registry/consul/ConsulServiceDiscovery.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <66.66%> (+0.58%) 31.00 <1.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 42.26% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcb02e...5d78f6a. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 82ff056 into apache:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiaoheng1 @codecov-io @AlbumenJ