Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6253 +/- ##
============================================
- Coverage 60.89% 60.81% -0.08%
+ Complexity 493 492 -1
============================================
Files 999 999
Lines 39898 39933 +35
Branches 5744 5752 +8
============================================
- Hits 24295 24286 -9
- Misses 12910 12945 +35
- Partials 2693 2702 +9 Continue to review full report at Codecov.
|
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #6231
Brief changelog
If only use spring,the allowBeanDefinitionOverriding is true, but when it comes to spring-boot,it is false. witch make it impossible to register beanDefinition duplicated.
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.