Skip to content

fix-6231#6253

Merged
mercyblitz merged 1 commit intoapache:masterfrom
kexianjun:fix-6231
Jun 1, 2020
Merged

fix-6231#6253
mercyblitz merged 1 commit intoapache:masterfrom
kexianjun:fix-6231

Conversation

@kexianjun
Copy link
Copy Markdown
Member

@kexianjun kexianjun commented Jun 1, 2020

What is the purpose of the change

fix #6231

Brief changelog

If only use spring,the allowBeanDefinitionOverriding is true, but when it comes to spring-boot,it is false. witch make it impossible to register beanDefinition duplicated.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6253 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6253      +/-   ##
============================================
- Coverage     60.89%   60.81%   -0.08%     
+ Complexity      493      492       -1     
============================================
  Files           999      999              
  Lines         39898    39933      +35     
  Branches       5744     5752       +8     
============================================
- Hits          24295    24286       -9     
- Misses        12910    12945      +35     
- Partials       2693     2702       +9     
Impacted Files Coverage Δ Complexity Δ
.../factory/annotation/ServiceClassPostProcessor.java 81.33% <100.00%> (ø) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
...java/org/apache/dubbo/rpc/support/MockInvoker.java 85.12% <0.00%> (-4.88%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/config/RegistryConfig.java 85.49% <0.00%> (-2.11%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 66.21% <0.00%> (-1.65%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0.00%> (-1.49%) 0.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df50c1...73e2d16. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dubbo 2.7.7 多次注册 DubboBootstrapApplicationListener

3 participants