Skip to content

fix typo in sample section for readme file#6251

Merged
htynkn merged 3 commits intoapache:masterfrom
lebron374:readme_fix
Jun 8, 2020
Merged

fix typo in sample section for readme file#6251
htynkn merged 3 commits intoapache:masterfrom
lebron374:readme_fix

Conversation

@lebron374
Copy link
Copy Markdown
Contributor

What is the purpose of the change

fix README.md faile

Brief changelog

public class GreetingsServiceImpl implements GreetingsService {

change to

public class GreetingServiceImpl implement GreetingService {

Verifying this change

public class GreetingsServiceImpl implements GreetingsService {

change to

public class GreetingServiceImpl implement GreetingService {

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 31, 2020

Codecov Report

Merging #6251 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6251      +/-   ##
============================================
- Coverage     60.87%   60.75%   -0.12%     
+ Complexity      494      491       -3     
============================================
  Files           999      999              
  Lines         39933    39933              
  Branches       5752     5752              
============================================
- Hits          24308    24262      -46     
- Misses        12926    12968      +42     
- Partials       2699     2703       +4     
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-5.00%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.35% <0.00%> (-4.28%) 0.00% <0.00%> (ø%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0.00%> (-3.75%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a827df...e5de902. Read the comment docs.

@lebron374
Copy link
Copy Markdown
Contributor Author

@htynkn htynkn changed the title readme fix fix typo in sample section for readme file Jun 4, 2020
@htynkn htynkn merged commit 9cd3086 into apache:master Jun 8, 2020
@htynkn
Copy link
Copy Markdown
Member

htynkn commented Jun 8, 2020

I fixed the mirror issue and merged into master.
Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants