Skip to content

fix config override with each other.#6236

Merged
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:fix-config-id-override
May 29, 2020
Merged

fix config override with each other.#6236
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:fix-config-id-override

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

do not set default id.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6236 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6236      +/-   ##
============================================
- Coverage     60.88%   60.86%   -0.03%     
+ Complexity      494      493       -1     
============================================
  Files           999      999              
  Lines         39921    39968      +47     
  Branches       5751     5765      +14     
============================================
+ Hits          24306    24325      +19     
- Misses        12922    12940      +18     
- Partials       2693     2703      +10     
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/dubbo/config/MethodConfig.java 98.73% <ø> (-0.04%) 0.00 <0.00> (ø)
...a/org/apache/dubbo/config/ReferenceConfigBase.java 59.59% <ø> (-0.81%) 0.00 <0.00> (ø)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 57.71% <ø> (-0.48%) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.35% <0.00%> (-4.28%) 0.00% <0.00%> (ø%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0.00%> (-3.75%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0.00%> (-3.28%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-2.86%) 16.00% <0.00%> (-1.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e11e7...605ab33. Read the comment docs.

@chickenlj chickenlj merged commit a0be776 into apache:master May 29, 2020
@chickenlj chickenlj deleted the fix-config-id-override branch June 1, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants