[Dubbo-6226] fix nacos service name associated with group name#6227
Merged
mercyblitz merged 1 commit intoapache:masterfrom Jun 1, 2020
Merged
[Dubbo-6226] fix nacos service name associated with group name#6227mercyblitz merged 1 commit intoapache:masterfrom
mercyblitz merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6227 +/- ##
============================================
- Coverage 60.85% 60.81% -0.04%
+ Complexity 493 492 -1
============================================
Files 999 999
Lines 39909 39909
Branches 5747 5747
============================================
- Hits 24287 24272 -15
- Misses 12925 12938 +13
- Partials 2697 2699 +2 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Make Nacos protocol support service discovery
fix #6226
Brief changelog
Using
NamingUtilsto decodeserviceNameget from Nacos which is actuallyserviceNameWithGroupinInstance.