Skip to content

[Dubbo-DynamicConfig] compatible configurators url with type JsonArray in ConfigCenter#6216

Merged
chickenlj merged 2 commits intoapache:masterfrom
imsunv:feature_configurators_url
May 28, 2020
Merged

[Dubbo-DynamicConfig] compatible configurators url with type JsonArray in ConfigCenter#6216
chickenlj merged 2 commits intoapache:masterfrom
imsunv:feature_configurators_url

Conversation

@imsunv
Copy link
Copy Markdown
Contributor

@imsunv imsunv commented May 25, 2020

Support URL Configurators with JsonArray in Dynamic Configuration
such as

[
  "override://0.0.0.0/com.xx.Service?category=configurators&timeout=6666&disabled=true&dynamic=false&enabled=true&group=dubbo&priority=1&version=1.0"
]

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 25, 2020

Codecov Report

Merging #6216 into master will increase coverage by 0.03%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6216      +/-   ##
============================================
+ Coverage     60.77%   60.80%   +0.03%     
  Complexity      491      491              
============================================
  Files           999      999              
  Lines         39909    39920      +11     
  Branches       5747     5749       +2     
============================================
+ Hits          24253    24272      +19     
+ Misses        12956    12947       -9     
- Partials       2700     2701       +1     
Impacted Files Coverage Δ Complexity Δ
.../rpc/cluster/configurator/parser/ConfigParser.java 87.61% <81.81%> (-0.63%) 0.00 <0.00> (ø)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-5.00%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0.00%> (-2.28%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0.00%> (-1.70%) 0.00% <0.00%> (ø%)
...etadata/report/support/AbstractMetadataReport.java 65.32% <0.00%> (-1.51%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.11% <0.00%> (ø) 30.00% <0.00%> (ø%)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 52.55% <0.00%> (+0.18%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.10% <0.00%> (+0.34%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) 16.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 78.63% <0.00%> (+4.27%) 0.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6b580...73c8507. Read the comment docs.

@chickenlj
Copy link
Copy Markdown
Contributor

LGTM.

@chickenlj chickenlj merged commit 1811f30 into apache:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants