fix concurrent bug (avoid NullPointerException)#6102
Closed
Augustvic wants to merge 2 commits intoapache:masterfrom
Augustvic:master
Closed
fix concurrent bug (avoid NullPointerException)#6102Augustvic wants to merge 2 commits intoapache:masterfrom Augustvic:master
Augustvic wants to merge 2 commits intoapache:masterfrom
Augustvic:master
Conversation
Member
|
@Augustvic hi, thanks for your contribution. The issue you mentioned has been resolved via #6793. Also, it would cause performance problems if you use Please feel free to reopen this pr if you still have any question, also you can create a new pr for related code. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Resolve concurrent bug (or NullPointerException) in DubboProtocol.java
Brief changelog
The statement "locks.get(key)" will get NULL after "locks.remove(key);", and then "synchronized(null)" will throw NullPointerException. Obviously, this two statement, "locks.putIfAbsent(key, new Object());" and "locks.get(key)", are not an atomic operation.
I can't find a better way to reduce lock granularity, maybe we have to sacrifice some performance to ensure safety here.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.