1、configuration.publishConfig returns false，without throw exception#6094
Merged
mercyblitz merged 2 commits intoapache:masterfrom May 6, 2020
Merged
1、configuration.publishConfig returns false，without throw exception#6094mercyblitz merged 2 commits intoapache:masterfrom
mercyblitz merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6094 +/- ##
============================================
+ Coverage 60.79% 60.83% +0.03%
- Complexity 492 493 +1
============================================
Files 998 998
Lines 39852 39860 +8
Branches 5739 5740 +1
============================================
+ Hits 24230 24250 +20
+ Misses 12929 12915 -14
- Partials 2693 2695 +2 Continue to review full report at Codecov.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fixes [#6093 ]
Brief changelog
configuration.publishConfig默认方法不再抛出异常，默认返回false，所以单元测试需要同步修改
Verifying this change
本地已完成测试