[Enhancement] Adding the overriding rule for ExtensionLoader#6068
Merged
chickenlj merged 8 commits intoapache:masterfrom Apr 29, 2020
Merged
[Enhancement] Adding the overriding rule for ExtensionLoader#6068chickenlj merged 8 commits intoapache:masterfrom
chickenlj merged 8 commits intoapache:masterfrom
Conversation
Contributor
|
I don't think it's necessary, and it make ExtensionLoader more complicated |
Contributor
Author
Or change to be simpler, reduce three classpaths to be one:
Just Leaving the first path will be better. |
…xtension.LoadingStrategy" into "dubbo-all" module.
Codecov Report
@@ Coverage Diff @@
## master #6068 +/- ##
============================================
- Coverage 60.97% 60.97% -0.01%
Complexity 492 492
============================================
Files 992 995 +3
Lines 39690 39704 +14
Branches 5723 5723
============================================
+ Hits 24202 24210 +8
- Misses 12808 12811 +3
- Partials 2680 2683 +3
Continue to review full report at Codecov.
|
Contributor
|
Notice that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtensionLoaderis a core API to extend the features of Dubbo components, it's based on the Dubbo's Service Provider mechanism that will search three classpaths in order :META-INF/dubbo/internal/META-INF/dubbo/META-INF/services/However, Dubbo framework just loads only one SPI file if found, does not support the overriding rule, for example :
The implementation in
META-INF/services/can overrideMETA-INF/dubbo/,META-INF/dubbo/can overrideMETA-INF/dubbo/internal/.