Skip to content

fix tomcat9 support. #5711#6066

Merged
beiwei30 merged 1 commit intoapache:masterfrom
hengyunabc:support_tomcat9
Apr 27, 2020
Merged

fix tomcat9 support. #5711#6066
beiwei30 merged 1 commit intoapache:masterfrom
hengyunabc:support_tomcat9

Conversation

@hengyunabc
Copy link
Copy Markdown
Contributor

@hengyunabc hengyunabc commented Apr 26, 2020

What is the purpose of the change

Support tomcat9.

#5711

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@hengyunabc hengyunabc requested review from beiwei30 and htynkn April 26, 2020 11:40
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 26, 2020 •
edited
Loading

Codecov Report

Merging #6066 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6066      +/-   ##
============================================
- Coverage     61.18%   61.12%   -0.07%     
+ Complexity      493      491       -2     
============================================
  Files           991      991              
  Lines         39597    39597              
  Branches       5719     5719              
============================================
- Hits          24227    24203      -24     
- Misses        12690    12703      +13     
- Partials       2680     2691      +11
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/remoting/http/tomcat/TomcatHttpServer.java 87.87% <100.00%> (ø) 0.00 <0.00> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0.00%> (-11.37%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 75.00% <0.00%> (-4.32%) 0.00% <0.00%> (ø%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0.00%> (-3.75%) 0.00% <0.00%> (ø%)
...exchange/support/header/HeaderExchangeHandler.java 61.94% <0.00%> (-2.66%) 0.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71ad15...09ed388. Read the comment docs.

beiwei30
beiwei30 approved these changes Apr 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beiwei30 beiwei30 merged commit 1505b18 into apache:master Apr 27, 2020
@AIphabet
Copy link
Copy Markdown

AIphabet commented May 30, 2020

什么时候会在2.6.x修复呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beiwei30 beiwei30 beiwei30 approved these changes

@htynkn htynkn Awaiting requested review from htynkn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hengyunabc @codecov-io @AIphabet @beiwei30