Skip to content

提供更优雅的异步方式实现 #606

Closed
yuyijq wants to merge 1 commit intoapache:masterfrom
yuyijq:async
Closed

提供更优雅的异步方式实现 #606
yuyijq wants to merge 1 commit intoapache:masterfrom
yuyijq:async

Conversation

@yuyijq
Copy link
Copy Markdown
Contributor

@yuyijq yuyijq commented Sep 6, 2017

用于在dubbo提供一种比较简单易用的异步方式,dubbo现有的各种异步方式使用起来怪异且晦涩。
这篇文章是当初实现的时候写的: https://mp.weixin.qq.com/s?__biz=MzAxMjQ5NDM1Mg==&mid=403540515&idx=1&sn=129354d83482ea44570254e909eea164&mpshare=1&scene=1&srcid=0906zp1tqI9iPgO5jID4lGlY&pass_ticket=ejLNVWu2aTn%2FesrGNKlr4YFzgoFMlolUj%2BZDHroifqBxyaOFeDJXV4R9DtjJNovj#rd

麻烦review一下,看看能不能进入官方代码里,谢谢

如果要使用这种方式的异步,除了引入dubbo包本身外,还需要引入
com.alibaba:dubbo-async

@chickenlj chickenlj added this to the 2.5.7 milestone Sep 14, 2017
* @author william.liangf
* @author chao.liuc
*/
public class FailoverClusterInvoker<T> extends AbstractClusterInvoker<T> {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有FailoverClusterInvoker实现了异步吗?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有FailoverClusterInvoker对于异步的方式需要特殊处理

@chickenlj chickenlj closed this Sep 27, 2017
@chickenlj chickenlj modified the milestones: 2.5.7, 2.5.8 Nov 1, 2017
@chickenlj chickenlj reopened this Nov 1, 2017
@chickenlj
Copy link
Copy Markdown
Contributor

@uglycow 请帮助review一下

@chickenlj chickenlj modified the milestones: 2.5.8, 2.5.9 Nov 28, 2017
@He-Pin
Copy link
Copy Markdown
Member

He-Pin commented Dec 29, 2017

这个方式怎么能够说优雅呢?又不是servlet。

@yuyijq
Copy link
Copy Markdown
Contributor Author

yuyijq commented Jan 12, 2018

@hepin1989 主要是和dubbo原来的方式相比,可以提出改进意见,望指教

@chickenlj chickenlj modified the milestones: 2.5.9, some day Mar 8, 2018
@ralf0131
Copy link
Copy Markdown
Contributor

ralf0131 commented Apr 8, 2018

This pull request has conflict, please resolve it before we can merge.

@ralf0131
Copy link
Copy Markdown
Contributor

ralf0131 commented Apr 8, 2018

Hi,

Please update the title and description using English. Dubbo is a global community and we would like the PR to be reviewed by people all over the world.

@afredlyj
Copy link
Copy Markdown

who can resolve the conflict?

@chickenlj
Copy link
Copy Markdown
Contributor

Hello yuyijq,
I have filed a new PR #1876 addressing this issue, referencing your ideas and implementations. Let's focus on #1876. Thanks for your contribution.

@chickenlj chickenlj closed this Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants