[Dubbo-Optimization]: polish ClassUtils#6003
Merged
chickenlj merged 1 commit intoapache:masterfrom Apr 24, 2020
Merged
Conversation
0b32e57 to
de0740a
Compare
Codecov Report
@@ Coverage Diff @@
## master #6003 +/- ##
=========================================
Coverage 61.21% 61.21%
Complexity 495 495
=========================================
Files 989 989
Lines 39300 39300
Branches 5649 5649
=========================================
Hits 24059 24059
Misses 12597 12597
Partials 2644 2644 Continue to review full report at Codecov.
|
- use loop instead of recursion
de0740a to
ef600fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
dubbo/dubbo-common/src/main/java/org/apache/dubbo/common/utils/ClassUtils.java
Lines 382 to 387 in 317e62f
like this:
Run test case https://github.com/apache/dubbo/blob/master/dubbo-common/src/test/java/org/apache/dubbo/convert/multiple/StringToBlockingDequeConverterTest.java
Output:
Output:
The log output is reduced from 432 lines to 198 lines.
Fell free to close it if it has be included in other PRs or It is not expected to change.
Brief changelog
getAllInterfaces/getAllSuperClasses.Verifying this change
Run test cases.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.