[Dubbo-5978] fix nacos-registry dubbo.registry.group no effect#5997
Merged
mercyblitz merged 2 commits intoapache:masterfrom Apr 28, 2020
Huangxuny1:nacos-group-issue
Merged
[Dubbo-5978] fix nacos-registry dubbo.registry.group no effect#5997mercyblitz merged 2 commits intoapache:masterfrom Huangxuny1:nacos-group-issue
mercyblitz merged 2 commits intoapache:masterfrom
Huangxuny1:nacos-group-issue
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5997 +/- ##
============================================
- Coverage 61.21% 61.14% -0.08%
+ Complexity 495 493 -2
============================================
Files 989 989
Lines 39300 39311 +11
Branches 5649 5649
============================================
- Hits 24059 24038 -21
- Misses 12597 12613 +16
- Partials 2644 2660 +16 Continue to review full report at Codecov.
|
Contributor
|
Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #5978
reproduce use git repo dubbo-spring-boot-samples/dubbo-registry-nacos-samples
just set
Brief changelog
the registryUrl contains key
groupwe can get registryUrl from
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/AbstractRegistry.java getUrl()Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.