Skip to content

fix:bad spell name#5921

Merged
chickenlj merged 1 commit intoapache:masterfrom
hellosx:master
Apr 1, 2020
Merged

fix:bad spell name#5921
chickenlj merged 1 commit intoapache:masterfrom
hellosx:master

Conversation

@hellosx
Copy link
Copy Markdown
Contributor

@hellosx hellosx commented Mar 26, 2020

What is the purpose of the change

modify bad spell name

Brief changelog

modify bad spell name

Verifying this change

modify bad spell name

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5921 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5921      +/-   ##
============================================
- Coverage     61.21%   61.16%   -0.06%     
+ Complexity      494      492       -2     
============================================
  Files           981      981              
  Lines         39106    39106              
  Branches       5620     5620              
============================================
- Hits          23939    23918      -21     
- Misses        12536    12564      +28     
+ Partials       2631     2624       -7     
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 65.21% <100.00%> (ø) 0.00 <0.00> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0.00%> (-3.75%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-3.41%) 19.00% <0.00%> (-1.00%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0.00%> (-2.98%) 0.00% <0.00%> (ø%)
...e/dubbo/registry/integration/RegistryProtocol.java 58.68% <0.00%> (-2.96%) 0.00% <0.00%> (ø%)
.../dubbo/registry/integration/RegistryDirectory.java 75.43% <0.00%> (-0.87%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/common/utils/UrlUtils.java 73.92% <0.00%> (-0.34%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.44% <0.00%> (+0.34%) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefe7c3...506731a. Read the comment docs.

@chickenlj chickenlj merged commit 4f286f5 into apache:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants