windows platform unittest adapt#5913
Merged
htynkn merged 27 commits intoapache:masterfrom Mar 26, 2020
Merged
Conversation
Member
Author
2 tasks
htynkn
reviewed
Mar 25, 2020
...eport-redis/src/test/java/org/apache/dubbo/metadata/store/redis/RedisMetadataReportTest.java
Outdated
Show resolved
Hide resolved
Member
|
thanks very much for your contribution. it's really nice to have hardcode port number to be replaced by Could you please take a look at my comment when you have time? |
…est-windows-fix # Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
Codecov Report
@@ Coverage Diff @@
## master #5913 +/- ##
============================================
- Coverage 61.22% 61.16% -0.06%
+ Complexity 496 491 -5
============================================
Files 981 981
Lines 39147 39106 -41
Branches 5645 5620 -25
============================================
- Hits 23968 23921 -47
+ Misses 12547 12546 -1
- Partials 2632 2639 +7 Continue to review full report at Codecov.
|
htynkn
reviewed
Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Making unit-test can be correctly running on Windows platform and fixing some static port, which is coded into test cases.
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.