Skip to content

Collect services by export asynchronously#5905

Merged
chickenlj merged 2 commits intoapache:masterfrom
wavesZh:unexported-patch
Apr 1, 2020
Merged

Collect services by export asynchronously#5905
chickenlj merged 2 commits intoapache:masterfrom
wavesZh:unexported-patch

Conversation

@wavesZh
Copy link
Copy Markdown
Contributor

@wavesZh wavesZh commented Mar 23, 2020

What is the purpose of the change

collect ServiceConfig by export asynchronously for unexport.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5905 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5905      +/-   ##
============================================
- Coverage     61.19%   61.12%   -0.08%     
+ Complexity      493      491       -2     
============================================
  Files           981      981              
  Lines         39106    39059      -47     
  Branches       5620     5587      -33     
============================================
- Hits          23932    23875      -57     
- Misses        12540    12552      +12     
+ Partials       2634     2632       -2     
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 53.81% <0.00%> (-0.11%) 0.00 <0.00> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80.00% <0.00%> (-7.50%) 0.00% <0.00%> (ø%)
...moting/transport/netty4/NettyEventLoopFactory.java 30.00% <0.00%> (-6.37%) 0.00% <0.00%> (ø%)
.../threadpool/support/limited/LimitedThreadPool.java 83.33% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...on/threadpool/support/cached/CachedThreadPool.java 85.71% <0.00%> (-4.29%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-3.41%) 19.00% <0.00%> (-1.00%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefe7c3...53f9ed0. Read the comment docs.

@chickenlj chickenlj merged commit 912303d into apache:master Apr 1, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.12%. Comparing base (cefe7c3) to head (53f9ed0).

Files with missing lines Patch % Lines
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5905      +/-   ##
============================================
- Coverage     61.21%   61.12%   -0.10%     
+ Complexity      494      491       -3     
============================================
  Files           981      981              
  Lines         39106    39059      -47     
  Branches       5620     5587      -33     
============================================
- Hits          23939    23875      -64     
- Misses        12536    12552      +16     
- Partials       2631     2632       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants