Skip to content

duplicate code in MulticastGroup.java and MulticastExchangeGroup.java#5898

Merged
htynkn merged 1 commit intoapache:masterfrom
DIscord010:duplicate_code
Mar 21, 2020
Merged

duplicate code in MulticastGroup.java and MulticastExchangeGroup.java#5898
htynkn merged 1 commit intoapache:masterfrom
DIscord010:duplicate_code

Conversation

@DIscord010
Copy link
Copy Markdown
Contributor

@DIscord010 DIscord010 commented Mar 21, 2020

duplicate code

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 21, 2020 •
edited
Loading

Codecov Report

Merging #5898 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5898      +/-   ##
============================================
- Coverage     61.21%   61.20%   -0.01%     
  Complexity      497      497              
============================================
  Files           981      981              
  Lines         39147    39140       -7     
  Branches       5645     5642       -3     
============================================
- Hits          23963    23956       -7     
+ Misses        12554    12553       -1     
- Partials       2630     2631       +1
Impacted Files Coverage Δ Complexity Δ
...g/p2p/exchange/support/MulticastExchangeGroup.java 77.50% <0.00%> (+5.15%) 0.00 <0.00> (ø)
...che/dubbo/remoting/p2p/support/MulticastGroup.java 82.50% <0.00%> (+5.90%) 0.00 <0.00> (ø)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 67.73% <42.85%> (-0.64%) 0.00 <0.00> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 56.52% <0.00%> (-6.53%) 0.00% <0.00%> (ø%)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-3.41%) 19.00% <0.00%> (-1.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 76.72% <0.00%> (-2.59%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bc261...3823a1a. Read the comment docs.

@htynkn htynkn self-assigned this Mar 21, 2020
@htynkn htynkn merged commit 7019f31 into apache:master Mar 21, 2020
@htynkn
Copy link
Copy Markdown
Member

htynkn commented Mar 21, 2020

thanks for your contribution

@DIscord010 DIscord010 deleted the duplicate_code branch March 22, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htynkn htynkn htynkn approved these changes

Assignees

@htynkn htynkn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DIscord010 @codecov-io @htynkn