Skip to content

remove duplicate config from .gitignore#5897

Merged
htynkn merged 1 commit intoapache:masterfrom
LiosWong:remove_duplicate_config
Mar 22, 2020
Merged

remove duplicate config from .gitignore#5897
htynkn merged 1 commit intoapache:masterfrom
LiosWong:remove_duplicate_config

Conversation

@LiosWong
Copy link
Copy Markdown
Contributor

@LiosWong LiosWong commented Mar 20, 2020

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 20, 2020 •
edited
Loading

Codecov Report

Merging #5897 into master will increase coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5897      +/-   ##
============================================
+ Coverage     61.21%   61.27%   +0.06%     
- Complexity      497      498       +1     
============================================
  Files           981      981              
  Lines         39147    39106      -41     
  Branches       5645     5620      -25     
============================================
+ Hits          23963    23964       +1     
+ Misses        12554    12523      -31     
+ Partials       2630     2619      -11
Impacted Files Coverage Δ Complexity Δ
...g/p2p/exchange/support/MulticastExchangeGroup.java 77.50% <0.00%> (+5.15%) 0.00 <0.00> (ø)
...che/dubbo/remoting/p2p/support/MulticastGroup.java 82.50% <0.00%> (+5.90%) 0.00 <0.00> (ø)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 67.73% <42.85%> (-0.64%) 0.00 <0.00> (ø)
...he/dubbo/rpc/cluster/merger/DoubleArrayMerger.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...pache/dubbo/rpc/cluster/merger/IntArrayMerger.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...rg/apache/dubbo/rpc/cluster/merger/ListMerger.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ache/dubbo/rpc/cluster/merger/LongArrayMerger.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...org/apache/dubbo/rpc/cluster/merger/MapMerger.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...org/apache/dubbo/rpc/cluster/merger/SetMerger.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 74.94% <100.00%> (-0.24%) 0.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bc261...8d21a04. Read the comment docs.

@htynkn
Copy link
Copy Markdown
Member

htynkn commented Mar 21, 2020

what's the purpose to remove .flattened-pom.xml file?
Could you provide more info in PR description

@LiosWong
Copy link
Copy Markdown
Contributor Author

LiosWong commented Mar 22, 2020

what's the purpose to remove .flattened-pom.xml file?
Could you provide more info in PR description

Sorry, my description is not clear. Because there are duplicate configuration items:

dubbo/.gitignore

Line 9 in 7019f31

.flattened-pom.xml

dubbo/.gitignore

Lines 34 to 35 in 7019f31

# flatten ignore
.flattened-pom.xml

@LiosWong LiosWong changed the title remove duplicate .flattened-pom.xml from .gitignore remove duplicate config from .gitignore Mar 22, 2020
@htynkn htynkn merged commit 4ba2580 into apache:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiosWong @codecov-io @htynkn