[Dubbo-Performance] Reuse Hessian2Output and Hessian2Input instance to reduce memor…#5889
Merged
chickenlj merged 1 commit intoapache:masterfrom Apr 7, 2020
Conversation
Contributor
Author
|
@chickenlj @beiwei30 PTAL. |
Member
|
I filed #5892 to track this task. |
6 tasks
Contributor
|
Does create Hessian2Input turns out to have an obvious performance affection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y allocation.
What is the purpose of the change
Reduce memory allocation.
Brief changelog
ThreadLocal<Hessian2Input>to create newHessian2ObjectInputinstance instead of create newHessian2Inputinstance.ThreadLocal<Hessian2Output>to create newHessian2ObjectOutputinstance instead of create newHessian2Outputinstance.Verifying this change
For more information: Hessian2Optimize
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.