[Dubbo-5872] use QOS command to check if app service is ready#5873
Merged
chickenlj merged 2 commits intoapache:masterfrom Apr 1, 2020
Hinsteny:origin
Merged
[Dubbo-5872] use QOS command to check if app service is ready#5873chickenlj merged 2 commits intoapache:masterfrom Hinsteny:origin
chickenlj merged 2 commits intoapache:masterfrom
Hinsteny:origin
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5873 +/- ##
============================================
- Coverage 61.33% 61.19% -0.14%
+ Complexity 500 496 -4
============================================
Files 981 982 +1
Lines 39147 39165 +18
Branches 5645 5648 +3
============================================
- Hits 24011 23968 -43
- Misses 12516 12561 +45
- Partials 2620 2636 +16 Continue to review full report at Codecov.
|
lkj41110
reviewed
Mar 28, 2020
|
|
||
| private AtomicBoolean started = new AtomicBoolean(false); | ||
|
|
||
| private AtomicBoolean ready = new AtomicBoolean(true); |
Contributor
There was a problem hiding this comment.
Why is the default value not false?
Contributor
Author
There was a problem hiding this comment.
Sometimes user would not call the DubboBootstrap.start method, so then the app ready function would not working, then the app should ready in default!
Contributor
|
I think ready should reflect more status than just checking exported services, but still, it's a good start, we can enhance it later. |
This was referenced Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add one QOS command to check application is ready or not!
Brief changelog
M dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
A dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/Ready.java
M dubbo-plugin/dubbo-qos/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.qos.command.BaseCommand
M dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/util/CommandHelperTest.java
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.