use Stream to refactor some code#5861
Merged
htynkn merged 1 commit intoapache:masterfrom Mar 21, 2020
Huangxuny1:huangxunyi/refactor
Merged
use Stream to refactor some code#5861htynkn merged 1 commit intoapache:masterfrom Huangxuny1:huangxunyi/refactor
htynkn merged 1 commit intoapache:masterfrom
Huangxuny1:huangxunyi/refactor
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5861 +/- ##
===========================================
- Coverage 61.24% 61.2% -0.05%
+ Complexity 499 496 -3
===========================================
Files 981 981
Lines 39142 39189 +47
Branches 5643 5647 +4
===========================================
+ Hits 23973 23984 +11
- Misses 12542 12573 +31
- Partials 2627 2632 +5
Continue to review full report at Codecov.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5861 +/- ##
============================================
- Coverage 61.24% 61.20% -0.05%
+ Complexity 499 496 -3
============================================
Files 981 981
Lines 39142 39189 +47
Branches 5643 5647 +4
============================================
+ Hits 23973 23984 +11
- Misses 12542 12573 +31
- Partials 2627 2632 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Simplified code use Java8 Stream
Brief changelog
M dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/DoubleArrayMerger.java
M dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/IntArrayMerger.java
M dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/ListMerger.java
M dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/LongArrayMerger.java
M dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/MapMerger.java
M dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/SetMerger.java
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.