Skip to content

polish: README.md#5859

Merged
htynkn merged 1 commit intoapache:masterfrom
Huangxuny1:huangxunyi/polish_readme
Mar 27, 2020
Merged

polish: README.md#5859
htynkn merged 1 commit intoapache:masterfrom
Huangxuny1:huangxunyi/polish_readme

Conversation

@huangxunyi
Copy link
Copy Markdown
Contributor

What is the purpose of the change

polish README.md , make sure hyperlink can jump to dubbo-samples Instead of 404


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@htynkn htynkn merged commit 9bd5152 into apache:master Mar 27, 2020
@htynkn
Copy link
Copy Markdown
Member

htynkn commented Mar 27, 2020

thanks very much for your contribution

@Huangxuny1 Huangxuny1 deleted the huangxunyi/polish_readme branch April 2, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants