Skip to content

void potential shutdown race condition.#5856

Merged
chickenlj merged 2 commits intoapache:2.7.6-releasefrom
chickenlj:shutdown
Mar 13, 2020
Merged

void potential shutdown race condition.#5856
chickenlj merged 2 commits intoapache:2.7.6-releasefrom
chickenlj:shutdown

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Mar 12, 2020

No description provided.

@chickenlj chickenlj mentioned this pull request Mar 12, 2020
Closed
2 tasks
@tswstarplanet
Copy link
Copy Markdown
Contributor

tswstarplanet commented Mar 12, 2020

I think it is right. But the destroyProtocols() method of DubboBootstrap is duplicate to destroyProtocols of DubboShutdownHook. I think we can delete the former to the later. And add a lock to the later one.

@chickenlj
Copy link
Copy Markdown
Contributor Author

chickenlj commented Mar 13, 2020

But the destroyProtocols() method of DubboBootstrap is duplicate to destroyProtocols of DubboShutdownHook

Done, now only DubboShutdownHook.destroyProtocols is kept.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 13, 2020 •
edited
Loading

Codecov Report

Merging #5856 into 2.7.6-release will increase coverage by 0.04%.
The diff coverage is 89.47%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.6-release    #5856      +/-   ##
===================================================
+ Coverage            61.14%   61.18%   +0.04%     
+ Complexity             496      495       -1     
===================================================
  Files                  981      981              
  Lines                39136    39128       -8     
  Branches              5643     5640       -3     
===================================================
+ Hits                 23928    23939      +11     
+ Misses               12576    12561      -15     
+ Partials              2632     2628       -4
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/config/context/ConfigManager.java 83.24% <ø> (ø) 0.00 <0.00> (ø)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 74.46% <66.66%> (-1.62%) 0.00 <0.00> (ø)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 53.50% <93.75%> (-0.42%) 0.00 <0.00> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0.00%> (-1.00%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.11% <0.00%> (-0.63%) 30.00% <0.00%> (ø%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.44% <0.00%> (+0.68%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) 16.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.31% <0.00%> (+4.31%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0.00%> (+8.33%) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8449017...a4dc509. Read the comment docs.

@chickenlj chickenlj merged commit 1b937ac into apache:2.7.6-release Mar 13, 2020
@AlbumenJ AlbumenJ mentioned this pull request Apr 3, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chickenlj @tswstarplanet @codecov-io