Skip to content

throw unknown exception#5849

Merged
chickenlj merged 1 commit intoapache:masterfrom
beiwei30:async-to-sync-invoker-exception
Mar 11, 2020
Merged

throw unknown exception#5849
chickenlj merged 1 commit intoapache:masterfrom
beiwei30:async-to-sync-invoker-exception

Conversation

@beiwei30
Copy link
Copy Markdown
Member

What is the purpose of the change

In AsyncToSyncInvoker, when ExecutionException happens, only TimeoutException and RemotingException are handled and wrapped as RpcException and re-throw. The problem here is other exception will be swallowed silently.

Brief changelog

wrap other exception in RpcException and rethrow.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from qinliujie March 11, 2020 07:25
@chickenlj
Copy link
Copy Markdown
Contributor

LGTM.

@chickenlj chickenlj closed this Mar 11, 2020
@chickenlj chickenlj reopened this Mar 11, 2020
@chickenlj chickenlj merged commit 61d1ba7 into apache:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants