Skip to content

Fix merge does not work.#5848

Merged
qinliujie merged 2 commits intoapache:2.7.6-releasefrom
chickenlj:fix-merge-invoker
Mar 12, 2020
Merged

Fix merge does not work.#5848
qinliujie merged 2 commits intoapache:2.7.6-releasefrom
chickenlj:fix-merge-invoker

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Mar 10, 2020

Follow up of (#5686), call getConsumerUrl.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 10, 2020 •
edited
Loading

Codecov Report

Merging #5848 into 2.7.6-release will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             2.7.6-release    #5848     +/-   ##
==================================================
+ Coverage             61.1%   61.21%   +0.1%     
  Complexity             497      497             
==================================================
  Files                  981      981             
  Lines                39137    39136      -1     
  Branches              5628     5643     +15     
==================================================
+ Hits                 23914    23956     +42     
+ Misses               12591    12549     -42     
+ Partials              2632     2631      -1
Impacted Files Coverage Δ Complexity Δ
...o/rpc/cluster/support/MergeableClusterInvoker.java 40% <0%> (-0.66%) 0 <0> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-6.82%) 19% <0%> (-1%)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0%> (-1%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.11% <0%> (ø) 30% <0%> (ø) ⬇️
...che/dubbo/common/compiler/support/JdkCompiler.java 63.2% <0%> (ø) 0% <0%> (ø) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 46.84% <0%> (+0.27%) 31% <0%> (ø) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (+0.68%) 0% <0%> (ø) ⬇️
...ache/dubbo/common/compiler/support/ClassUtils.java 50.26% <0%> (+1.04%) 0% <0%> (ø) ⬇️
...apache/dubbo/metadata/rest/RestMethodMetadata.java 51.47% <0%> (+1.47%) 0% <0%> (ø) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ff2ef...eba52eb. Read the comment docs.

@qinliujie
Copy link
Copy Markdown
Contributor

qinliujie commented Mar 12, 2020

LGTM

@qinliujie qinliujie merged commit 8449017 into apache:2.7.6-release Mar 12, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.21%. Comparing base (e0ff2ef) to head (eba52eb).

Files with missing lines Patch % Lines
...o/rpc/cluster/support/MergeableClusterInvoker.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##             2.7.6-release    #5848      +/-   ##
===================================================
+ Coverage            61.10%   61.21%   +0.10%     
  Complexity             497      497              
===================================================
  Files                  981      981              
  Lines                39137    39136       -1     
  Branches              5628     5643      +15     
===================================================
+ Hits                 23914    23956      +42     
+ Misses               12591    12549      -42     
+ Partials              2632     2631       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chickenlj @codecov-io @qinliujie @codecov-commenter