Skip to content

add some test cases for RpcUtils#5844

Merged
chickenlj merged 1 commit intoapache:masterfrom
Huangxuny1:huangxunyi/test
Apr 2, 2020
Merged

add some test cases for RpcUtils#5844
chickenlj merged 1 commit intoapache:masterfrom
Huangxuny1:huangxunyi/test

Conversation

@Huangxuny1
Copy link
Copy Markdown
Contributor

@Huangxuny1 Huangxuny1 commented Mar 9, 2020

What is the purpose of the change

add some tests for org.apache.dubbo.rpc.support.RpcUtils

Brief changelog

test RpcUtils.getReturnType
test RpcUtils.getParameterTypes
test RpcUtils.getMethodName

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #5844 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5844      +/-   ##
============================================
+ Coverage     61.22%   61.36%   +0.14%     
  Complexity      497      497              
============================================
  Files           981      981              
  Lines         39137    39225      +88     
  Branches       5643     5673      +30     
============================================
+ Hits          23962    24072     +110     
+ Misses        12549    12514      -35     
- Partials       2626     2639      +13
Impacted Files Coverage Δ Complexity Δ
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-6.78%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0%> (-1%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (-0.35%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.73% <0%> (+0.62%) 30% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.52% <0%> (+0.95%) 17% <0%> (+1%) ⬆️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 81.81% <0%> (+2.65%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.04% <0%> (+2.97%) 0% <0%> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 72.84% <0%> (+3.84%) 0% <0%> (ø) ⬇️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 90% <0%> (+7.29%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d7fc1...e32222c. Read the comment docs.

@Huangxuny1 Huangxuny1 changed the title add some tests for RpcUtils add some test cases for RpcUtils Mar 10, 2020
@Huangxuny1 Huangxuny1 closed this Mar 13, 2020
@Huangxuny1 Huangxuny1 deleted the huangxunyi/test branch March 13, 2020 02:31
@Huangxuny1 Huangxuny1 restored the huangxunyi/test branch March 13, 2020 06:01
@Huangxuny1 Huangxuny1 reopened this Mar 17, 2020
@chickenlj chickenlj merged commit 93d412b into apache:master Apr 2, 2020
@Huangxuny1 Huangxuny1 deleted the huangxunyi/test branch April 2, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Huangxuny1 @codecov-io @htynkn @chickenlj