Skip to content

fix config-center configured in dubbo.properties does not work.#5811

Merged
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:load-configcenter-from-properties
Feb 28, 2020
Merged

fix config-center configured in dubbo.properties does not work.#5811
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:load-configcenter-from-properties

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Feb 28, 2020 •
edited
Loading

fixes #5777

@chickenlj chickenlj mentioned this pull request Feb 28, 2020
Closed
2 tasks
@chickenlj chickenlj merged commit ca28815 into apache:master Feb 28, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 28, 2020

Codecov Report

Merging #5811 into master will decrease coverage by <.01%.
The diff coverage is 47.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5811      +/-   ##
============================================
- Coverage     61.22%   61.21%   -0.01%     
  Complexity      496      496              
============================================
  Files           982      981       -1     
  Lines         39117    39143      +26     
  Branches       5637     5644       +7     
============================================
+ Hits          23948    23961      +13     
- Misses        12540    12552      +12     
- Partials       2629     2630       +1
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 53.91% <47.82%> (-0.67%) 0 <0> (ø)
...ache/dubbo/rpc/protocol/ProtocolFilterWrapper.java 63.79% <0%> (-5.85%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
.../dubbo/registry/integration/RegistryDirectory.java 75.14% <0%> (-0.87%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 69% <0%> (-0.55%) 0% <0%> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 62.46% <0%> (-0.28%) 0% <0%> (ø)
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 65.21% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/org/apache/dubbo/rpc/ListenableFilter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...api/src/main/java/org/apache/dubbo/rpc/Filter.java
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b0d7e...3a01c4d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dubbo 2.7.5 problems summary

2 participants

@chickenlj @codecov-io