Skip to content

fix metadata config does not take effect#5809

Merged
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:metadata-remote
Feb 28, 2020
Merged

fix metadata config does not take effect#5809
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:metadata-remote

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Feb 28, 2020 •
edited
Loading

fixes #5742

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #5809 into master will decrease coverage by 0.15%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5809      +/-   ##
============================================
- Coverage     61.38%   61.23%   -0.16%     
- Complexity      495      496       +1     
============================================
  Files           979      982       +3     
  Lines         38893    39123     +230     
  Branches       5606     5639      +33     
============================================
+ Hits          23876    23957      +81     
- Misses        12392    12530     +138     
- Partials       2625     2636      +11
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 69% <33.33%> (-0.55%) 0 <0> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 62.46% <33.33%> (-0.28%) 0 <0> (ø)
...org/apache/dubbo/rpc/service/GenericException.java 0% <0%> (-37.5%) 0% <0%> (ø)
...rc/main/java/org/apache/dubbo/rpc/AppResponse.java 55.07% <0%> (-12.93%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 63.35% <0%> (-10.7%) 0% <0%> (ø)
...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java 48.51% <0%> (-6.44%) 0% <0%> (ø)
...mmon/threadpool/support/AbortPolicyWithReport.java 83.78% <0%> (-5.41%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.31% <0%> (-3.58%) 0% <0%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048fadf...301c85f. Read the comment docs.

@chickenlj chickenlj added this to the 2.7.6 milestone Feb 28, 2020
@chickenlj chickenlj merged commit 2a7b5d1 into apache:master Feb 28, 2020
@yyzx428 yyzx428 mentioned this pull request Mar 19, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.6

Development

Successfully merging this pull request may close these issues.

Dubbo2.7.5 使用Zookeeper元数据中心，元数据未上报

2 participants

@chickenlj @codecov-io