Skip to content

Duplicate condition in 'if' statement inspection#5802

Merged
tswstarplanet merged 1 commit intoapache:masterfrom
LiosWong:duplicate_condition
Feb 29, 2020
Merged

Duplicate condition in 'if' statement inspection#5802
tswstarplanet merged 1 commit intoapache:masterfrom
LiosWong:duplicate_condition

Conversation

@LiosWong
Copy link
Copy Markdown
Contributor

@LiosWong LiosWong commented Feb 26, 2020 •
edited
Loading

What is the purpose of the change

fix Duplicate condition in 'if' statement inspection

dubbo/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcInvoker.java

Lines 99 to 103 in 0f4e60d

if (status.getCode() == Status.Code.DEADLINE_EXCEEDED) {
return RpcException.TIMEOUT_EXCEPTION;
} else if (status.getCode() == Status.Code.DEADLINE_EXCEEDED) {
//
}

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 26, 2020 •
edited
Loading

Codecov Report

Merging #5802 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5802      +/-   ##
============================================
- Coverage     61.43%   61.36%   -0.08%     
+ Complexity      497      496       -1     
============================================
  Files           979      979              
  Lines         38888    38887       -1     
  Branches       5605     5604       -1     
============================================
- Hits          23891    23863      -28     
- Misses        12374    12402      +28     
+ Partials       2623     2622       -1
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/rpc/protocol/grpc/GrpcInvoker.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 46.15% <0%> (-30.77%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0%> (-10.53%) 15% <0%> (-1%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (-8.34%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.27% <0%> (-3.61%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.35% <0%> (-2.99%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0%> (-1.99%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.11% <0%> (-0.63%) 30% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.44% <0%> (+0.34%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4e60d...2c5177b. Read the comment docs.

@tswstarplanet
Copy link
Copy Markdown
Contributor

tswstarplanet commented Feb 29, 2020

LGTM

@tswstarplanet tswstarplanet merged commit 35e80b0 into apache:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiosWong @codecov-io @tswstarplanet