Skip to content

Remove duplicate dependency from [dubbo-bom] and [dubbo-demo-xml-cons…#5799

Merged
chickenlj merged 1 commit intoapache:masterfrom
LiosWong:duplicate_dependency
Feb 28, 2020
Merged

Remove duplicate dependency from [dubbo-bom] and [dubbo-demo-xml-cons…#5799
chickenlj merged 1 commit intoapache:masterfrom
LiosWong:duplicate_dependency

Conversation

@LiosWong
Copy link
Copy Markdown
Contributor

@LiosWong LiosWong commented Feb 26, 2020

…umer]

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 26, 2020 •
edited
Loading

Codecov Report

Merging #5799 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5799      +/-   ##
============================================
- Coverage     61.43%   61.37%   -0.06%     
  Complexity      497      497              
============================================
  Files           979      979              
  Lines         38888    38888              
  Branches       5605     5605              
============================================
- Hits          23891    23868      -23     
- Misses        12374    12397      +23     
  Partials       2623     2623
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 46.15% <0%> (-30.77%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (-8.34%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.27% <0%> (-3.61%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.35% <0%> (-2.99%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0%> (-2.28%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0%> (-1.99%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
.../dubbo/registry/integration/RegistryDirectory.java 75.14% <0%> (-0.87%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.11% <0%> (-0.63%) 30% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4e60d...88b1e61. Read the comment docs.

@chickenlj chickenlj merged commit 54b0d7e into apache:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiosWong @codecov-io @chickenlj