Skip to content

[Dubbo-4697] Fix PojoUtils support localdatetime,lcaldate,localtime#5783

Merged
htynkn merged 3 commits intoapache:masterfrom
CrazyHZM:supportMoreTypesConvert
Feb 26, 2020
Merged

[Dubbo-4697] Fix PojoUtils support localdatetime,lcaldate,localtime#5783
htynkn merged 3 commits intoapache:masterfrom
CrazyHZM:supportMoreTypesConvert

Conversation

@CrazyHZM
Copy link
Copy Markdown
Member

@CrazyHZM CrazyHZM commented Feb 24, 2020

What is the purpose of the change

#4697

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 24, 2020 •
edited
Loading

Codecov Report

Merging #5783 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5783      +/-   ##
============================================
- Coverage     61.49%   61.33%   -0.17%     
+ Complexity      497      495       -2     
============================================
  Files           979      979              
  Lines         38871    38880       +9     
  Branches       5602     5605       +3     
============================================
- Hits          23905    23846      -59     
- Misses        12351    12406      +55     
- Partials       2615     2628      +13
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/utils/CompatibleTypeUtils.java 68.46% <100%> (+2.12%) 0 <0> (ø) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 46.15% <0%> (-30.77%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 70.83% <0%> (-16.67%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 75.67% <0%> (-13.52%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0%> (-10.53%) 15% <0%> (-1%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
...common/serialize/hessian2/Hessian2ObjectInput.java 94.11% <0%> (-5.89%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-5.09%) 0% <0%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f1c18...9881c24. Read the comment docs.

@htynkn htynkn changed the title Fix #4697 PojoUtils support localdatetime,lcaldate,localtime [Dubbo-4697] Fix PojoUtils support localdatetime,lcaldate,localtime Feb 26, 2020
@htynkn htynkn merged commit 0f4e60d into apache:master Feb 26, 2020
@CrazyHZM CrazyHZM deleted the supportMoreTypesConvert branch February 26, 2020 09:03
@kaori-seasons kaori-seasons mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htynkn htynkn htynkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CrazyHZM @codecov-io @htynkn