Skip to content

expose configuration api#5774

Merged
cvictory merged 1 commit intoapache:masterfrom
chickenlj:polish-configuration-api
Feb 25, 2020
Merged

expose configuration api#5774
cvictory merged 1 commit intoapache:masterfrom
chickenlj:polish-configuration-api

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Feb 21, 2020

No description provided.

cvictory
cvictory approved these changes Feb 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 22, 2020

Codecov Report

Merging #5774 into master will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #5774      +/-   ##
===========================================
- Coverage     61.42%   61.4%   -0.03%     
+ Complexity      498     496       -2     
===========================================
  Files           979     979              
  Lines         38828   38879      +51     
  Branches       5569    5602      +33     
===========================================
+ Hits          23851   23873      +22     
- Misses        12360   12380      +20     
- Partials       2617    2626       +9
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/common/config/Environment.java 91.25% <0%> (-6.09%) 0 <0> (ø)
...apache/dubbo/common/config/ConfigurationUtils.java 67.85% <50%> (-4.15%) 0 <0> (ø)
...port/identifier/BaseServiceMetadataIdentifier.java 67.85% <0%> (-4.88%) 0% <0%> (ø)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0%> (-3.85%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-3.41%) 19% <0%> (-1%)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0%> (-2.28%) 0% <0%> (ø)
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0%> (-2%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0%> (-1.7%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.27% <0%> (-1.1%) 0% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d99d6...9114ea4. Read the comment docs.

@cvictory cvictory merged commit 195b074 into apache:master Feb 25, 2020
@chickenlj chickenlj deleted the polish-configuration-api branch April 20, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cvictory cvictory cvictory approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chickenlj @codecov-io @cvictory