[Dubbo-Optimization] polish NetUtils#matchIpRange#5773
Merged
chickenlj merged 1 commit intoapache:masterfrom Apr 2, 2020
Merged
[Dubbo-Optimization] polish NetUtils#matchIpRange#5773chickenlj merged 1 commit intoapache:masterfrom
chickenlj merged 1 commit intoapache:masterfrom
Conversation
7c2179b to
8d074c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #5773 +/- ##
============================================
- Coverage 61.42% 61.38% -0.04%
+ Complexity 498 496 -2
============================================
Files 979 979
Lines 38828 38869 +41
Branches 5569 5600 +31
============================================
+ Hits 23851 23861 +10
- Misses 12360 12384 +24
- Partials 2617 2624 +7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Optimize method
NetUtils#matchIpRangeI have searched in opened PR.
Fell free to close it if it has be included in other PRs or It is not expected to change.
Brief changelog
sstoignoredbecause it is never be used.condition?:true:false->conditionStringUtils#split(String,char)instead ofString#split(regex)ipAddresswhen it will be used immediatelyVerifying this change
The current test case 'NetUtilsTest' is enough.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.