Skip to content

register stated url to provider model, no matter the provider is configured to delay-published or not#5757

Merged
chickenlj merged 2 commits intoapache:masterfrom
beiwei30:stated-url
Apr 3, 2020
Merged

register stated url to provider model, no matter the provider is configured to delay-published or not#5757
chickenlj merged 2 commits intoapache:masterfrom
beiwei30:stated-url

Conversation

@beiwei30
Copy link
Copy Markdown
Member

What is the purpose of the change

to make sure stated url on provider model always correct.

Brief changelog

register stated url to provider model, no matter the provider is configured to delay-published or not.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from qinliujie February 18, 2020 10:18
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5757 into master will decrease coverage by 0.2%.
The diff coverage is 60.2%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5757      +/-   ##
============================================
- Coverage     61.39%   61.19%   -0.21%     
- Complexity      496      497       +1     
============================================
  Files           980      981       +1     
  Lines         38829    39144     +315     
  Branches       5568     5644      +76     
============================================
+ Hits          23841    23956     +115     
- Misses        12363    12557     +194     
- Partials       2625     2631       +6
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dubbo/rpc/model/ServiceDescriptor.java 91.17% <ø> (+2.94%) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/RegistryConfig.java 87.59% <ø> (-0.1%) 0 <0> (ø)
...pache/dubbo/config/spring/util/DubboBeanUtils.java 100% <ø> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <ø> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <ø> (ø) 9 <0> (ø) ⬇️
.../metadata/store/RemoteWritableMetadataService.java 77.31% <ø> (ø) 0 <0> (ø) ⬇️
...src/main/java/org/apache/dubbo/rpc/Invocation.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...nfig/bootstrap/builders/MetadataReportBuilder.java 97.36% <ø> (ø) 0 <0> (ø) ⬇️
.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java 23.1% <ø> (+0.16%) 0 <0> (ø) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 122c56d...de64f79. Read the comment docs.

@chickenlj
Copy link
Copy Markdown
Contributor

LGTM.

@chickenlj chickenlj self-requested a review April 2, 2020 13:34
@chickenlj chickenlj added this to the 2.7.7 milestone Apr 2, 2020
@qinliujie
Copy link
Copy Markdown
Contributor

LGTM

@chickenlj chickenlj merged commit 5d6ca62 into apache:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants