fix: spelling incorrect#5749
Merged
htynkn merged 1 commit intoapache:masterfrom Feb 26, 2020
LiosWong:spelling_incorrect
Merged
fix: spelling incorrect#5749htynkn merged 1 commit intoapache:masterfrom LiosWong:spelling_incorrect
htynkn merged 1 commit intoapache:masterfrom
LiosWong:spelling_incorrect
Conversation
htynkn
reviewed
Feb 26, 2020
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(DubboBeanDefinitionParser.class); | ||
| private static final Pattern GROUP_AND_VERION = Pattern.compile("^[\\-.0-9_a-zA-Z]+(\\:[\\-.0-9_a-zA-Z]+)?$"); | ||
| private static final Pattern GROUP_AND_VERSION = Pattern.compile("^[\\-.0-9_a-zA-Z]+(\\:[\\-.0-9_a-zA-Z]+)?$"); |
Member
There was a problem hiding this comment.
I only see this name change, but where do we use this value?
Contributor
Author
There was a problem hiding this comment.
Nowhere to use it, consider remove it
Member
|
LGTM. I don't think this PR will fail CI, I'm trying to restart CI again to see how it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix some spelling incorrect
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.