Skip to content

some code optimization#5746

Merged
htynkn merged 2 commits intoapache:masterfrom
ZZMarquis:master
Mar 26, 2020
Merged

some code optimization#5746
htynkn merged 2 commits intoapache:masterfrom
ZZMarquis:master

Conversation

@ZZMarquis
Copy link
Copy Markdown
Contributor

@ZZMarquis ZZMarquis commented Feb 16, 2020

What is the purpose of the change

some code optimization

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 16, 2020 •
edited
Loading

Codecov Report

Merging #5746 into master will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5746      +/-   ##
============================================
+ Coverage     61.24%   61.27%   +0.02%     
- Complexity      422      496      +74     
============================================
  Files           922      928       +6     
  Lines         37498    37947     +449     
  Branches       5431     5480      +49     
============================================
+ Hits          22967    23252     +285     
- Misses        12055    12167     +112     
- Partials       2476     2528      +52
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/common/bytecode/ClassGenerator.java 61.53% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <100%> (ø) 16 <0> (ø) ⬇️
...g/context/properties/DefaultDubboConfigBinder.java 0% <0%> (-100%) 0% <0%> (ø)
...t/annotation/DubboLifecycleComponentRegistrar.java 0% <0%> (-100%) 0% <0%> (ø)
...ache/dubbo/rpc/cluster/support/ForkingCluster.java 0% <0%> (-100%) 0% <0%> (ø)
.../context/properties/AbstractDubboConfigBinder.java 0% <0%> (-92.31%) 0% <0%> (ø)
...ring/context/config/DubboConfigBeanCustomizer.java 0% <0%> (-66.67%) 0% <0%> (ø)
...che/dubbo/rpc/cluster/support/FailfastCluster.java 50% <0%> (-50%) 0% <0%> (ø)
.../org/apache/dubbo/rpc/model/ServiceRepository.java 63.63% <0%> (-14.42%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-13.8%) 0% <0%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b288ad7...b110fa4. Read the comment docs.

@htynkn htynkn merged commit 7dbe632 into apache:master Mar 26, 2020
@htynkn
Copy link
Copy Markdown
Member

htynkn commented Mar 26, 2020

thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htynkn htynkn htynkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZZMarquis @codecov-io @htynkn