Skip to content

[Dubbo-fix] fix typo CHARECTER -> CHARACTER#5744

Merged
CodingSinger merged 1 commit intoapache:masterfrom
tangcent:fix-typo
Feb 15, 2020
Merged

[Dubbo-fix] fix typo CHARECTER -> CHARACTER#5744
CodingSinger merged 1 commit intoapache:masterfrom
tangcent:fix-typo

Conversation

@tangcent
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix typo CHARECTER -> CHARACTER.
I have searched in opened PR.
Fell free to close it if it has be included in other PRs or It is not expected to change.

Brief changelog

Only rename SPLIT_IPV4_CHARECTER &SPLIT_IPV6_CHARECTER
to SPLIT_IPV4_CHARACTER &SPLIT_IPV6_CHARACTER .

Verifying this change

These two private variables do not affect the other methods or classes except getRandomPort .
The current test case 'NetUtilsTest' is enough.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5744 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5744      +/-   ##
============================================
- Coverage     61.32%   61.29%   -0.03%     
+ Complexity      498      496       -2     
============================================
  Files           928      928              
  Lines         37947    37947              
  Branches       5480     5480              
============================================
- Hits          23270    23260      -10     
- Misses        12153    12160       +7     
- Partials       2524     2527       +3
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/common/utils/NetUtils.java 67.7% <100%> (ø) 0 <0> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0%> (-4.55%) 20% <0%> (-1%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.11% <0%> (-0.63%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2031110...a1e8c47. Read the comment docs.

@CodingSinger
Copy link
Copy Markdown
Member

LGTM

@CodingSinger CodingSinger merged commit d30ca86 into apache:master Feb 15, 2020
@tangcent tangcent deleted the fix-typo branch February 21, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants