Skip to content

fix #5256#5724

Merged
chickenlj merged 1 commit intoapache:masterfrom
qinliujie:fix/5256
Feb 10, 2020
Merged

fix #5256#5724
chickenlj merged 1 commit intoapache:masterfrom
qinliujie:fix/5256

Conversation

@qinliujie
Copy link
Copy Markdown
Contributor

@qinliujie qinliujie commented Feb 10, 2020

What is the purpose of the change

fix #5256

Brief changelog

MessageOnlyChannelHandler add sendFeedback

@qinliujie qinliujie requested a review from chickenlj February 10, 2020 07:46
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 10, 2020 •
edited
Loading

Codecov Report

Merging #5724 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5724      +/-   ##
============================================
- Coverage     61.43%   61.41%   -0.03%     
+ Complexity      497      496       -1     
============================================
  Files           930      930              
  Lines         38079    38082       +3     
  Branches       5481     5497      +16     
============================================
- Hits          23393    23387       -6     
- Misses        12149    12152       +3     
- Partials       2537     2543       +6
Impacted Files Coverage Δ Complexity Δ
.../dispatcher/message/MessageOnlyChannelHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...bo/config/event/listener/LoggingEventListener.java 37.5% <0%> (-25%) 0% <0%> (ø)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 65.95% <0%> (-14.9%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (-8.34%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.27% <0%> (-3.61%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0%> (-1.99%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0%> (-1.7%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a62b55...2b3b312. Read the comment docs.

@chickenlj chickenlj merged commit c9f12ca into apache:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chickenlj chickenlj Awaiting requested review from chickenlj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The MessageOnlyChannelHandler class should be consistent with the writing of the ExecutionChannelHandler class.

3 participants

@qinliujie @codecov-io @chickenlj