Skip to content

Remove duplicate dependency from dubbo-config-spring#5716

Merged
kun-song merged 3 commits intoapache:masterfrom
kun-song:enhance-code
Feb 6, 2020
Merged

Remove duplicate dependency from dubbo-config-spring#5716
kun-song merged 3 commits intoapache:masterfrom
kun-song:enhance-code

Conversation

@kun-song
Copy link
Copy Markdown
Contributor

@kun-song kun-song commented Feb 6, 2020

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 6, 2020

Codecov Report

Merging #5716 into master will increase coverage by 0.18%.
The diff coverage is 75.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5716      +/-   ##
============================================
+ Coverage     61.24%   61.42%   +0.18%     
- Complexity      422      497      +75     
============================================
  Files           922      930       +8     
  Lines         37503    38045     +542     
  Branches       5434     5487      +53     
============================================
+ Hits          22967    23371     +404     
- Misses        12058    12143      +85     
- Partials       2478     2531      +53
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/dubbo/remoting/Constants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...bo/rpc/cluster/interceptor/ClusterInterceptor.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 61.5% <ø> (-2.3%) 0 <0> (ø)
...va/org/apache/dubbo/common/utils/ReflectUtils.java 69.87% <ø> (-0.16%) 0 <0> (ø)
...che/dubbo/common/compiler/support/JdkCompiler.java 63.2% <ø> (-1.34%) 0 <0> (ø)
...org/apache/dubbo/config/AbstractServiceConfig.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 62.73% <ø> (+0.82%) 0 <0> (ø) ⬇️
...src/main/java/org/apache/dubbo/common/Version.java 62.62% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/RegistryConfig.java 87.69% <ø> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/config/ReferenceConfigBase.java 60.39% <ø> (ø) 0 <0> (ø) ⬇️
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e355c...92048b2. Read the comment docs.

@kun-song kun-song merged commit 66131d2 into apache:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kun-song @codecov-io