Skip to content

check the metadataServiceExporter when exec ShutdownHookCallbacks#5650

Merged
chickenlj merged 1 commit intoapache:masterfrom
CodingSinger:BUG_FIX
Feb 1, 2020
Merged

check the metadataServiceExporter when exec ShutdownHookCallbacks#5650
chickenlj merged 1 commit intoapache:masterfrom
CodingSinger:BUG_FIX

Conversation

@CodingSinger
Copy link
Copy Markdown
Member

@CodingSinger CodingSinger commented Jan 14, 2020

Fixed NPE caused by metadataServiceExporter not being initialized when executing ShutdownHookCallbacks

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 14, 2020 •
edited
Loading

Codecov Report

Merging #5650 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5650      +/-   ##
============================================
- Coverage     61.24%   61.08%   -0.16%     
  Complexity      421      421              
============================================
  Files           922      922              
  Lines         37498    37499       +1     
  Branches       5431     5431              
============================================
- Hits          22965    22907      -58     
- Misses        12056    12106      +50     
- Partials       2477     2486       +9
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 53.4% <0%> (-0.32%) 0 <0> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 30.76% <0%> (-15.39%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-13.8%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0%> (-10.53%) 15% <0%> (-1%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0%> (-8.48%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (-8.34%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.27% <0%> (-7.21%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0%> (-6.94%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b288ad7...c3a148e. Read the comment docs.

@chickenlj chickenlj merged commit 901c463 into apache:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chickenlj chickenlj Awaiting requested review from chickenlj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CodingSinger @codecov-io @chickenlj