Skip to content

Remove registry from factory that already destroyed. #5483#5608

Merged
qinliujie merged 1 commit intoapache:masterfrom
guohao:fix5483
Feb 5, 2020
Merged

Remove registry from factory that already destroyed. #5483#5608
qinliujie merged 1 commit intoapache:masterfrom
guohao:fix5483

Conversation

@guohao
Copy link
Copy Markdown
Contributor

@guohao guohao commented Jan 9, 2020 •
edited
Loading

What is the purpose of the change

Fix #5483

Remove registry from factory that already destroyed.

@chickenlj @qinliujie

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 19, 2020

Codecov Report

Merging #5608 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #5608      +/-   ##
===========================================
- Coverage     61.21%   61.2%   -0.02%     
- Complexity      422     423       +1     
===========================================
  Files           922     923       +1     
  Lines         37498   37577      +79     
  Branches       5431    5442      +11     
===========================================
+ Hits          22956   23000      +44     
- Misses        12060   12087      +27     
- Partials       2482    2490       +8
Impacted Files Coverage Δ Complexity Δ
...pache/dubbo/registry/support/AbstractRegistry.java 77.98% <100%> (-2.17%) 0 <0> (ø)
...ubbo/registry/support/AbstractRegistryFactory.java 80% <100%> (+9.41%) 0 <0> (ø) ⬇️
...ache/dubbo/validation/filter/ValidationFilter.java 75% <0%> (-10.72%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 59.09% <0%> (-9.1%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-6.78%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0%> (-4.55%) 20% <0%> (-1%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...ache/dubbo/registry/multiple/MultipleRegistry.java 59.35% <0%> (-3.33%) 22% <0%> (+2%)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f264dac...7b3d7e9. Read the comment docs.

@qinliujie
Copy link
Copy Markdown
Contributor

qinliujie commented Feb 5, 2020

LGTM

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Feb 5, 2020

LGTM.

@qinliujie qinliujie merged commit 2c9d7f5 into apache:master Feb 5, 2020
@guohao guohao deleted the fix5483 branch February 5, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Registry调用destroy为什么不清除AbstractRegistryFactory中的缓存

4 participants

@guohao @codecov-io @qinliujie @chickenlj