Skip to content

[Dubbo-5606] Fix RpcContext.asyncCall return when throw RpcException#5607

Merged
chickenlj merged 2 commits intoapache:masterfrom
mr3:master
Feb 9, 2020
Merged

[Dubbo-5606] Fix RpcContext.asyncCall return when throw RpcException#5607
chickenlj merged 2 commits intoapache:masterfrom
mr3:master

Conversation

@mr3
Copy link
Copy Markdown
Contributor

@mr3 mr3 commented Jan 9, 2020 •
edited
Loading

What is the purpose of the change

Fix issue[#5606]

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@mr3 mr3 changed the title Fix RpcContext.asyncCall return when throw RpcException #5606 [Dubbo-5606] Fix RpcContext.asyncCall return when throw RpcException Jan 9, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 9, 2020 •
edited
Loading

Codecov Report

Merging #5607 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5607      +/-   ##
============================================
- Coverage     61.26%   61.21%   -0.06%     
  Complexity      422      422              
============================================
  Files           922      922              
  Lines         37498    37495       -3     
  Branches       5431     5431              
============================================
- Hits          22974    22953      -21     
- Misses        12048    12056       +8     
- Partials       2476     2486      +10
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/apache/dubbo/rpc/RpcContext.java 80.6% <100%> (+7.39%) 0 <0> (ø) ⬇️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 70.83% <0%> (-16.67%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 75.67% <0%> (-13.52%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 59.09% <0%> (-9.1%) 0% <0%> (ø)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 55% <0%> (-5%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0%> (-1.99%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0%> (-1.91%) 16% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.41% <0%> (-0.69%) 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dabc7a...5695000. Read the comment docs.

@chickenlj chickenlj merged commit 6d1afb4 into apache:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mr3 @codecov-io @chickenlj