Skip to content

[Dubbo-5592] Simplify code of getExtensionLoader method#5593

Merged
htynkn merged 1 commit intoapache:masterfrom
huangdx0726:fix5592
Mar 21, 2020
Merged

[Dubbo-5592] Simplify code of getExtensionLoader method#5593
htynkn merged 1 commit intoapache:masterfrom
huangdx0726:fix5592

Conversation

@huangdx0726
Copy link
Copy Markdown
Contributor

What is the purpose of the change

fix #5592

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@htynkn htynkn assigned htynkn and unassigned htynkn Jan 7, 2020
@htynkn
Copy link
Copy Markdown
Member

htynkn commented Jan 7, 2020

CI fail.
I cleaned cache and ci is rebuiliding now https://travis-ci.org/apache/dubbo/builds/633572460?utm_source=github_status&utm_medium=notification

@huangdx0726
Copy link
Copy Markdown
Contributor Author

What can i do for it?

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
Copy link
Copy Markdown

What can i do for it?

You can submit a merge request once and trigger the ci check again.

@htynkn
Copy link
Copy Markdown
Member

htynkn commented Mar 21, 2020

this change looks ok to me. but somehow CI still fail for this PR.
Currently travis is in maintain, I will try again when it back

@htynkn htynkn self-assigned this Mar 21, 2020
@htynkn htynkn merged commit 7a73b3f into apache:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The getExtensionLoader method code in ExtensionLoader file should be Simplified

3 participants