Skip to content

optimize : optimize document specifications#5587

Merged
chickenlj merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-15
Feb 1, 2020
Merged

optimize : optimize document specifications#5587
chickenlj merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-15

Conversation

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
Copy link
Copy Markdown

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz commented Jan 4, 2020

What is the purpose of the change

optimize document specifications

Brief changelog

1.dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/configurator/AbstractConfigurator.java

Verifying this change

Passed unit tests

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 4, 2020

Codecov Report

Merging #5587 into master will decrease coverage by 0.09%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #5587     +/-   ##
===========================================
- Coverage     61.29%   61.19%   -0.1%     
+ Complexity      424      422      -2     
===========================================
  Files           922      922             
  Lines         37502    37502             
  Branches       5431     5431             
===========================================
- Hits          22985    22948     -37     
- Misses        12042    12070     +28     
- Partials       2475     2484      +9
Impacted Files Coverage Δ Complexity Δ
...rpc/cluster/configurator/AbstractConfigurator.java 63.79% <50%> (ø) 0 <0> (ø) ⬇️
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 59.09% <0%> (-9.1%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (-8.34%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-7.96%) 19% <0%> (-2%)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.27% <0%> (-7.21%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-6.78%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5dc6e...291f65d. Read the comment docs.

@chickenlj chickenlj merged commit 36fde9e into apache:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beiwei30 beiwei30 Awaiting requested review from beiwei30

@chickenlj chickenlj Awaiting requested review from chickenlj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz @codecov-io @chickenlj